Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved git lfs configuration on gitea configuration closes #65 #66

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

TheRojam
Copy link
Contributor

i added variables to the j2 template for gitea.ini regarding git lfs remote usage.
of course i updated the readme.md (in the second commit)
this closes also the issue #65 of this repo.

please review, discuss w/ me and approve/deny this PR.

git lfs can be hosted elsewhere and therefore need some config
@TheRojam
Copy link
Contributor Author

tbh, please add ubuntu 20.04 to the to be tested distros

@TheRojam
Copy link
Contributor Author

added new config vars, please review and merge.
may you can check why travis fails?

@TheRojam
Copy link
Contributor Author

@DO1JLR could you check this?

Copy link
Contributor

@DO1JLR DO1JLR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically quite good. There are still a few flaws missing like no trailing whitespace.

defaults/main.yml Show resolved Hide resolved
templates/gitea.ini.j2 Show resolved Hide resolved
templates/gitea.ini.j2 Outdated Show resolved Hide resolved
@TheRojam
Copy link
Contributor Author

Basically quite good. There are still a few flaws missing like no trailing whitespace.

u can check again :)

@thomas-maurice
Copy link
Owner

Nice, thank you for doing this, can you have a look at why the CI is failing ? It seems the Gitea instance fails to start

@TheRojam
Copy link
Contributor Author

sadly i do not know.. and i did not see your checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants