fix: DataCollectorHook event time converted to seconds (#2750)

thomaspoignant · Dec 4, 2024 · 61dc4bc · 61dc4bc
1 parent bafe9dc
commit 61dc4bc
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/...lag-kotlin-provider/src/main/java/org/gofeatureflag/openfeature/hook/DataCollectorHook.kt b/...lag-kotlin-provider/src/main/java/org/gofeatureflag/openfeature/hook/DataCollectorHook.kt
@@ -14,7 +14,7 @@ class DataCollectorHook<T>(private val collectorManager: DataCollectorManager) :
     ) {
         val event = Event(
             contextKind = "user",
-            creationDate = Date().time,
+            creationDate = Date().time / 1000L,
             key = ctx.flagKey,
             kind = "feature",
             userKey = ctx.ctx?.getTargetingKey(),
@@ -29,7 +29,7 @@ class DataCollectorHook<T>(private val collectorManager: DataCollectorManager) :
     override fun error(ctx: HookContext<T>, error: Exception, hints: Map<String, Any>) {
         val event = Event(
             contextKind = "user",
-            creationDate = Date().time,
+            creationDate = Date().time / 1000L,
             key = ctx.flagKey,
             kind = "feature",
             userKey = ctx.ctx?.getTargetingKey(),
@@ -40,4 +40,4 @@ class DataCollectorHook<T>(private val collectorManager: DataCollectorManager) :
         )
         collectorManager.addEvent(event)
     }
-}
+}
diff --git a/...n-provider/src/test/java/org/gofeatureflag/openfeature/controller/GoFeatureFlagApiTest.kt b/...n-provider/src/test/java/org/gofeatureflag/openfeature/controller/GoFeatureFlagApiTest.kt
@@ -21,7 +21,7 @@ class GoFeatureFlagApiTest {
     private var defaultEventList: List<Event> = listOf(
         Event(
             contextKind = "contextKind",
-            creationDate = 1721650841108,
+            creationDate = 1721650841,
             key = "flag-1",
             kind = "feature",
             userKey = "981f2662-1fb4-4732-ac6d-8399d9205aa9",
@@ -140,4 +140,4 @@ class GoFeatureFlagApiTest {
         val got = recordedRequest.body.readUtf8()
         JSONAssert.assertEquals(want, got, false)
     }
-}
+}
diff --git a/...g-kotlin-provider/src/test/resources/org/gofeatureflag/openfeature/hook/valid_result.json b/...g-kotlin-provider/src/test/resources/org/gofeatureflag/openfeature/hook/valid_result.json
@@ -2,7 +2,7 @@
   "events": [
     {
       "contextKind": "contextKind",
-      "creationDate": 1721650841108,
+      "creationDate": 1721650841,
       "key": "flag-1",
       "kind": "feature",
       "userKey": "981f2662-1fb4-4732-ac6d-8399d9205aa9",
@@ -11,7 +11,7 @@
       "variation": "enabled"
     }
   ],
-  "metadata": {
+  "meta": {
     "provider": "android",
     "openfeature": "true"
   }