fix: proper init for log test

thomaspoignant · Nov 4, 2024 · a2ba621 · a2ba621
1 parent e6db682
commit a2ba621
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/cmd/relayproxy/api/opentelemetry/otel_test.go b/cmd/relayproxy/api/opentelemetry/otel_test.go
@@ -213,7 +213,12 @@ func TestInit(t *testing.T) {
 
 		expectedErr := errors.New("test error")
 
-		err := svc.Init(context.Background(), testLogger, config.Config{})
+		t.Setenv("OTEL_EXPORTER_OTLP_ENDPOINT", "https://example.com:4318")
+		f := pflag.NewFlagSet("config", pflag.ContinueOnError)
+		c, errC := config.New(f, zap.L(), "1.X.X")
+		require.NoError(t, errC)
+		c.OpenTelemetryOtlpEndpoint = "https://bogus.com:4317"
+		err := svc.Init(context.Background(), testLogger, *c)
 		require.NoError(t, err)
 		defer func() { _ = svc.Stop(context.Background()) }()
 		otel.GetErrorHandler().Handle(expectedErr)

diff --git a/go.mod b/go.mod
@@ -11,6 +11,7 @@ require (
 	github.com/aws/aws-sdk-go v1.55.5
 	github.com/aws/aws-sdk-go-v2 v1.32.2
 	github.com/aws/aws-sdk-go-v2/config v1.28.0
+	github.com/aws/aws-sdk-go-v2/credentials v1.17.41
 	github.com/aws/aws-sdk-go-v2/feature/s3/manager v1.17.34
 	github.com/aws/aws-sdk-go-v2/service/kinesis v1.32.2
 	github.com/aws/aws-sdk-go-v2/service/s3 v1.66.1
@@ -88,7 +89,6 @@ require (
 	github.com/apache/arrow/go/arrow v0.0.0-20200730104253-651201b0f516 // indirect
 	github.com/apache/thrift v0.14.2 // indirect
 	github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.6.6 // indirect
-	github.com/aws/aws-sdk-go-v2/credentials v1.17.41 // indirect
 	github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.17 // indirect
 	github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.21 // indirect
 	github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.21 // indirect