-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for multiple exporters #2535
base: main
Are you sure you want to change the base?
feat: support for multiple exporters #2535
Conversation
✅ Deploy Preview for go-feature-flag-doc-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2535 +/- ##
==========================================
+ Coverage 84.81% 85.56% +0.75%
==========================================
Files 100 100
Lines 4346 4414 +68
==========================================
+ Hits 3686 3777 +91
+ Misses 535 506 -29
- Partials 125 131 +6 ☔ View full report in Codecov by Sentry. |
1235b8a
to
b64acf6
Compare
@hoangnv-bkhn I haven't looked in detail to all the PR but there is something I would have done differently. In your proposal you are duplicating the logic of the While I understand why you've done that I think it will be easier to have only 1 flush interval for all the exporters. Any reason why you have not followed that path? |
@thomaspoignant For example, with S3 or Google Cloud Storage, it may be better to use a longer flush interval and a higher maximum buffer because they are designed for batch uploads. Sending data in larger batches can reduce the number of requests and improve throughput. |
Quality Gate passedIssues Measures |
@thomaspoignant If you think that the idea of all exporters having the same flush interval and max buffer configuration makes more sense at the moment, then we can reconsider it. |
@hoangnv-bkhn Sorry I am lagging with the reviews those days. My main concern with your solution is that you add events to each exporters which means that we duplicate the usage of memory by the number of exporters and I want to avoid that as much as possible. I am still trying to understand what is the best solution here, but I am happy to get your inputs. |
@thomaspoignant |
Description
Each data exporter will be initialized with a separate schedule to operate independently of each other.
Refer: Example
Closes issue(s)
Resolve #2505
Checklist
README.md
and/website/docs
)