feat: Added Microsoft Teams Notifier #2633
Conversation
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2633 +/- ##
==========================================
+ Coverage 85.04% 85.24% +0.20%
==========================================
Files 102 103 +1
Lines 4720 4847 +127
==========================================
+ Hits 4014 4132 +118
- Misses 561 567 +6
- Partials 145 148 +3 ☔ View full report in Codecov by Sentry. |
|
hello @thomaspoignant kindly review :) |
There was a problem hiding this comment.
@martinvibes we are super close to be able to merge this PR.
I've made a few suggestions, when done we will be able to merge the PR.
cmd/relayproxy/config/notifier.go
Outdated
| Headers map[string][]string `mapstructure:"headers" koanf:"headers"` | ||
| WebhookURL string `mapstructure:"webhookUrl" koanf:"webhookurl"` | ||
| SlackWebhookURL string `mapstructure:"slackWebhookUrl" koanf:"slackWebhookUrl"` | ||
| MicrosoftTeamsWebhookURL string `mapstructure:"microsoftteamsWebhookUrl" koanf:"microsoftteamsWebhookUrl"` |
There was a problem hiding this comment.
🎯 suggestion: Instead of using a new field here I would suggest to re-use WebhookURL that is generic enough to be used in association of the microsoftteams kind field.
| Short bool `json:"short"` | ||
| } | ||
|
|
||
| type ByTitle []Field |
There was a problem hiding this comment.
| type ByTitle []Field | |
| type ByTitle []Field |
🎯 suggestion: ByTitle does not have to be public I would suggest to put this struct as private.
|
|
hello @thomaspoignant kindly review :) |
Description
Closes issue(s)
Resolve #2556
Checklist
README.mdand/website/docs)