Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codebase/spring-cloud-aws-s3 #302

Merged

Conversation

hardikSinghBehl
Copy link
Contributor

@hardikSinghBehl hardikSinghBehl commented Apr 16, 2024

Please review the changes you did in this PR and check these points to make sure that the code examples are of high quality:

  • the source branch for this PR is NOT the master branch of your fork (please create a dedicated branch for the PR)
  • the PR doesn't contain code that is irrelevant to the topic of the article
  • the PR doesn't contain any other files that are irrelevant to the topic of the article
  • the PR contains a README.md file that explains in a sentence or two what the code example is about and links to the article on reflectoring.io (if you added to an existing module, please add the link to the existing README.md file)
  • the code is covered with tests where it makes sense
  • if you have created a new Maven or Gradle module, please add it to the CI build (search for "# ADD NEW MODULES HERE" in build-all.sh)
  • used the latest Gradle or Maven version
  • used Java 11 or later
  • the GitHub Actions build is successful for your PR branch

Feel free to raise the PR even if the checklist hasn't been worked through, yet. But please only flag it to be reviewed after going through the checklist above.

Also feel free to reach out if you have any trouble with any of the steps.

@hardikSinghBehl hardikSinghBehl marked this pull request as draft April 25, 2024 09:22
@hardikSinghBehl hardikSinghBehl marked this pull request as ready for review April 28, 2024 10:12
@Maiklins Maiklins merged commit e5c8216 into thombergs:master May 27, 2024
0 of 7 checks passed
@hardikSinghBehl hardikSinghBehl deleted the codebase/spring-cloud-aws-s3 branch May 27, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants