-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace timezonefinder
with tzfpy
#176
Open
mvexel
wants to merge
8
commits into
thomersch:master
Choose a base branch
from
mvexel:mvexel/timezonepackage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+169
−298
Commits on Jul 11, 2024
-
1. add GDAL to dev dependencies 2. `poetry update`, mainly to pull in a newer `requests` to replace 2.32.0 which has a security vulnerability
Configuration menu - View commit details
-
Copy full SHA for ba6dad3 - Browse repository at this point
Copy the full SHA ba6dad3View commit details -
replace timezonefinder with tzfpy
the timezonefinder package [does not seem to be maintained anymore](https://github.com/jannikmi/timezonefinder/tree/master?tab=readme-ov-file#notice-looking-for-maintainers-reach-out-if-you-want-to-contribute). Moreover, it introduces numpy as a transient dependency, which seems heavy-handed.
Configuration menu - View commit details
-
Copy full SHA for 9951250 - Browse repository at this point
Copy the full SHA 9951250View commit details -
Configuration menu - View commit details
-
Copy full SHA for b140050 - Browse repository at this point
Copy the full SHA b140050View commit details -
Revert "removing
timezonefinder
"This reverts commit b140050. Does not belong in this PR :)
Configuration menu - View commit details
-
Copy full SHA for 413f773 - Browse repository at this point
Copy the full SHA 413f773View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad2d42b - Browse repository at this point
Copy the full SHA ad2d42bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad8c7c3 - Browse repository at this point
Copy the full SHA ad8c7c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9621f2c - Browse repository at this point
Copy the full SHA 9621f2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21d82fc - Browse repository at this point
Copy the full SHA 21d82fcView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.