📚 Update development and testing details #41
Conversation
sesheta
added
the
size/M
|
Can't we also include the smaug instance (destination) directly in the |
.env.template
Outdated
|
|
||
| # dest ceph | ||
| THOTH_DOCUMENT_SYNC_DST="s3://thoth/data/test" | ||
| AWS_ACCESS_KEY_ID= | ||
| AWS_SECRET_ACCESS_KEY= |
There was a problem hiding this comment.
Assuming smaug as target, we would have :
AWS_ENDPOINT_URL=https://s3-openshift-storage.apps.smaug.na.operate-first.cloud correct ?
(This env var does not work, override the url by env var is not yet implemented in either boto3 or aws-cli, but the value are correct ?)
basing this on https://console-openshift-console.apps.smaug.na.operate-first.cloud/k8s/ns/thoth-infra-prod/configmaps/ceph
There was a problem hiding this comment.
The url is correct, i would update the documentation on where to place the endpoint as well.
There was a problem hiding this comment.
I'm not sure what short term solution we can have regarding this. Creating a config file under $HOME (I think aws-cli / boto3 check under ~/.aws/config or something like that is not super pratictal).
Long-term I think we would want thoth-station/storages#2700
There was a problem hiding this comment.
Or maybe we could put everything in THOTH_DOCUMENT_SYNC_DST (like https://s3-openshift-storage.apps.smaug.na.operate-first.cloud/thoth/what/ever).
The lack of a standard env var in aws/boto3 is quite a pain :/
There was a problem hiding this comment.
yeah this is a pain, if we are using the aws cli then we can rely on --endpoint .
However as I saw with your pr, it using boto3 and python module,maybe we can use the env var for this.
for now I have include a note for current setup.
There was a problem hiding this comment.
I can add an --endpoint flag with a env fallback to the command, with click it's quite trivial. (In fact I have a local commit to do just that that I used for testing).
There was a problem hiding this comment.
that would be great, seems like a convenient option as of now.
| THOTH_CEPH_KEY_ID= | ||
| THOTH_CEPH_SECRET_KEY= |
There was a problem hiding this comment.
Don't we need credentials with this ? from python or aws-cli I get the same error -> Unable to locate credentials.
There was a problem hiding this comment.
yes we do, you can get the credential from the cluster.
source: https://console-openshift-console.apps.ocp4.prod.psi.redhat.com/k8s/ns/thoth-test-core/secrets/ceph
dest: https://console-openshift-console.apps.smaug.na.operate-first.cloud/k8s/ns/thoth-frontend-prod/secrets/ceph
I would like to include these detail in thoth-application docs,
so I have included the link to this in this document.
There was a problem hiding this comment.
Right, this ought to be in a more general place than here 👍
harshad16
force-pushed
the
update-docs
branch
2 times, most recently
from
4ab161b
to
a108fcb
Compare
Signed-off-by: Harshad Reddy Nalla <[email protected]> Update .env.template Co-authored-by: Max Gautier <[email protected]>
|
Lets get this in , wdyt @VannTen ? |
|
Yeah we're good. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Update development and testing details
Signed-off-by: Harshad Reddy Nalla [email protected]