Implemented antenna calibration API with backwards compatibility #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented simple antenna calibration APi with retro-compatibility.
Co-authored-by: an4cr0n <[email protected]>
|
@an4cr0n So #244 is obsolete with this pull request? |
|
In my opinion, yes. We wait for @an4cr0n |
|
@Rotzbua depends if you want to include the python scripts in the other one, but i think they don't belong here. |
|
@Sonic0 @an4cr0n thanks for your pull request 👍 , i merged them before i basically abandon this lib, i hope your code helps others |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple improvement based on pull request #244 but doesn't break backwards compatibility.