Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert stylesheets to use css custom properties #2755

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edwardloveall
Copy link
Contributor

Supporting #2732

This converts all sass color variables (and a couple other variables) to use native css variables instead.

There's a lot here! If you'd prefer, I can figure out how to break this up into smaller parts; maybe one per var or something. It also doesn't get rid of all sass variables. I could go even farther and do that if we want. Just let me know.

@nickcharlton
Copy link
Member

Thanks! Yeah, it's a bit big!

It also doesn't get rid of all sass variables. I could go even farther and do that if we want.

…have you seen a path to removing Sass entirely? That'd be fun.

@edwardloveall
Copy link
Contributor Author

Thanks! Yeah, it's a bit big!

Cool, I'll work on breaking it up.

…have you seen a path to removing Sass entirely? That'd be fun.

I think so. I haven't done a full audit or anything but css has come a long way. I think the blocking factor would be which old browsers does administrate need to support.

@edwardloveall edwardloveall marked this pull request as draft February 28, 2025 01:14
@edwardloveall edwardloveall changed the title Convert stylesheet colors to use css vars Convert stylesheets to use css vars Feb 28, 2025
@edwardloveall edwardloveall changed the title Convert stylesheets to use css vars Convert stylesheets to use css custom properties Feb 28, 2025
@edwardloveall
Copy link
Contributor Author

edwardloveall commented Feb 28, 2025

Alright here's a start with a much smaller scope. I see two ways forward:

  • I ship just this PR and follow up with about 20 (give or take 10) of a similar size converting a couple vars at a time.
  • I keep going on this branch so it's one var per commit until we've done em all, but at least you can review one commit at a time.

Preference? I lean toward the one branch thing since it's less branch juggling for me, but you probably have more to keep track of as maintainer so I think this is up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants