Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorManagement: Add ColorManagement.define( { ... } ) #1297

Merged
merged 8 commits into from
Oct 23, 2024
Merged

ColorManagement: Add ColorManagement.define( { ... } ) #1297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2f590a1
ColorManagement: Add ColorManagement.define( { ... } )
Methuselah96 Oct 23, 2024
6ce747d
Fix
Methuselah96 Oct 23, 2024
e7dc201
Update three.js
Methuselah96 Oct 23, 2024
3e1c754
Add src
Methuselah96 Oct 23, 2024
c9afacb
Update patch and delete src
Methuselah96 Oct 23, 2024
0dcd6fe
Add ColorSpaces
Methuselah96 Oct 23, 2024
b5575cb
Add examples
Methuselah96 Oct 23, 2024
8db0b2f
Update patch and delete examples
Methuselah96 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions examples-testing/changes.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12486,10 +12486,10 @@ index 366a2791..74077e99 100644
+ console.log('after', renderer.info.programs!.length);
}
diff --git a/examples-testing/examples/webgl_test_wide_gamut.ts b/examples-testing/examples/webgl_test_wide_gamut.ts
index 693dd459..5e64e184 100644
index 5988299e..6da2af6c 100644
--- a/examples-testing/examples/webgl_test_wide_gamut.ts
+++ b/examples-testing/examples/webgl_test_wide_gamut.ts
@@ -2,12 +2,12 @@ import * as THREE from 'three';
@@ -9,12 +9,12 @@ import {

import WebGL from 'three/addons/capabilities/WebGL.js';

Expand All @@ -12503,9 +12503,9 @@ index 693dd459..5e64e184 100644
-const slider = document.querySelector('.slider');
+const slider = document.querySelector('.slider') as HTMLElement;

const isP3Context = WebGL.isColorSpaceAvailable(THREE.DisplayP3ColorSpace);
const isP3Context = WebGL.isColorSpaceAvailable(DisplayP3ColorSpace);

@@ -18,7 +18,7 @@ if (isP3Context) {
@@ -30,7 +30,7 @@ if (isP3Context) {
init();

function init() {
Expand All @@ -12514,7 +12514,7 @@ index 693dd459..5e64e184 100644

sceneL = new THREE.Scene();
sceneR = new THREE.Scene();
@@ -60,7 +60,7 @@ async function initTextures() {
@@ -72,7 +72,7 @@ async function initTextures() {
}

function initSlider() {
Expand All @@ -12523,7 +12523,7 @@ index 693dd459..5e64e184 100644
if (event.isPrimary === false) return;

window.addEventListener('pointermove', onPointerMove);
@@ -72,10 +72,10 @@ function initSlider() {
@@ -84,10 +84,10 @@ function initSlider() {
window.removeEventListener('pointerup', onPointerUp);
}

Expand All @@ -12536,7 +12536,7 @@ index 693dd459..5e64e184 100644
}

updateSlider(sliderPos);
@@ -84,7 +84,7 @@ function initSlider() {
@@ -96,7 +96,7 @@ function initSlider() {
slider.addEventListener('pointerdown', onPointerDown);
}

Expand All @@ -12545,7 +12545,7 @@ index 693dd459..5e64e184 100644
sliderPos = Math.max(10, Math.min(window.innerWidth - 10, offset));

slider.style.left = sliderPos - slider.offsetWidth / 2 + 'px';
@@ -96,13 +96,13 @@ function onWindowResize() {
@@ -108,13 +108,13 @@ function onWindowResize() {

renderer.setSize(window.innerWidth, window.innerHeight);

Expand All @@ -12559,7 +12559,7 @@ index 693dd459..5e64e184 100644

-function onGamutChange({ matches }) {
+function onGamutChange({ matches }: MediaQueryListEvent) {
renderer.outputColorSpace = isP3Context && matches ? THREE.DisplayP3ColorSpace : THREE.SRGBColorSpace;
renderer.outputColorSpace = isP3Context && matches ? DisplayP3ColorSpace : THREE.SRGBColorSpace;

textureL.needsUpdate = true;
diff --git a/examples-testing/examples/webgl_texture2darray_compressed.ts b/examples-testing/examples/webgl_texture2darray_compressed.ts
Expand Down
Loading
Loading