Update ObjectLoader.d.ts #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept Records instead of Arrays
.parseMaterials returns a record of materials, not an array
Remove inaccurate comments.
Methuselah96
requested changes
Apr 25, 2023
| parseAnimations(json: Record<string, any>): Record<string, AnimationClip>; | ||
| parseImages(json: Record<string, any>, onLoad?: () => void): { [key: string]: Source }; | ||
| parseImagesAsync(json: Record<string, any>): Promise<{ [key: string]: Source }>; | ||
| parseTextures(json: Record<string, any>, images: any): Record<string, Texture>; |
There was a problem hiding this comment.
Just spot-checking this against source, it seems like json is treated as an array here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept Records instead of Arrays, Missing argument in
ObjectLoader.parseObjectWhy#399
If you look at ObjectLoader.parseObject#L683
You'll notice that they're accepting textures as an argument before animations
I you look at getGeometry you'll notice that the
geometriesis expected to be an object/recordI you look at getMaterial you'll notice that the
materialsis expected to be an object/recordSame goes for getTexture which was missing in the arguments in
ObjectLoader.d.tsThose arguments are then passed to
parseImages,parseAnimations,parseMaterials,.parseGeometriesetc...Ref: .parseImages#L363