Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: matching ip address with gateway #178

Merged
merged 1 commit into from
May 28, 2024

Conversation

sameh-farouk
Copy link
Member

What's changed:

  • Checking whether both the IP address and gateway address are the same (as part of the previously added IP validation rules) didn't function correctly in the previous release. This patch ensures that it runs correctly.

Logs show that this validation at work:

{"level":3,"time":1716915040735,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/16, Gateway: 1.1.1.1"}
{"level":3,"time":1716915097216,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 10.1.2.4/25, Gateway: 10.1.2.4"}
{"level":3,"time":1716915104602,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 192.168.0.0/16, Gateway: 192.168.0.0"}
{"level":3,"time":1716915118340,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/24, Gateway: 1.1.1.1"}
{"level":3,"time":1716915118360,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/24, Gateway: 1.1.1.1"}
{"level":3,"time":1716915123167,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 0.0.0.201/16, Gateway: 0.0.0.201"}
{"level":3,"time":1716915128148,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/24, Gateway: 1.1.1.1"}
{"level":3,"time":1716915128154,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/24, Gateway: 1.1.1.1"}
{"level":3,"time":1716915128160,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/24, Gateway: 1.1.1.1"}
{"level":3,"time":1716915128169,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/24, Gateway: 1.1.1.1"}
{"level":3,"time":1716915128186,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/24, Gateway: 1.1.1.1"}
{"level":3,"time":1716915131097,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 142.12.14.1/24, Gateway: 142.12.14.1"}
{"level":3,"time":1716915138956,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/16, Gateway: 1.1.1.1"}
{"level":3,"time":1716915154461,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.0.0.1/32, Gateway: 1.0.0.1"}
{"level":3,"time":1716915169086,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.0.0.1/32, Gateway: 1.0.0.1"}
{"level":3,"time":1716915183304,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 121.64.32.15/16, Gateway: 121.64.32.15"}
{"level":3,"time":1716915183624,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 121.64.32.15/16, Gateway: 121.64.32.15"}
{"level":3,"time":1716915215309,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/16, Gateway: 1.1.1.1"}
{"level":3,"time":1716915254692,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 142.12.14.1/24, Gateway: 142.12.14.1"}
{"level":3,"time":1716915254692,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/16, Gateway: 1.1.1.1"}
{"level":3,"time":1716915254696,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 142.12.14.1/24, Gateway: 142.12.14.1"}
{"level":3,"time":1716915254702,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 142.12.14.1/24, Gateway: 142.12.14.1"}
{"level":3,"time":1716915254703,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/16, Gateway: 1.1.1.1"}
{"level":3,"time":1716915254707,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 142.12.14.1/24, Gateway: 142.12.14.1"}
{"level":3,"time":1716915254707,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/16, Gateway: 1.1.1.1"}
{"level":3,"time":1716915254766,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 142.12.14.1/24, Gateway: 142.12.14.1"}
{"level":3,"time":1716915254767,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/16, Gateway: 1.1.1.1"}
{"level":3,"time":1716915254812,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 142.12.14.1/24, Gateway: 142.12.14.1"}
{"level":3,"time":1716915254812,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/16, Gateway: 1.1.1.1"}
{"level":3,"time":1716915254827,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 142.12.14.1/24, Gateway: 142.12.14.1"}
{"level":3,"time":1716915254827,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 1.1.1.1/16, Gateway: 1.1.1.1"}
{"level":3,"time":1716915254905,"ns":"sqd:processor:mapping","msg":"The IP addresses are the same. Public IP: 142.12.14.1/24, Gateway: 142.12.14.1"}

@sameh-farouk sameh-farouk merged commit 474c7c6 into master May 28, 2024
1 check passed
@sameh-farouk sameh-farouk deleted the master-fix-matching-ip-address-with-gateway branch May 28, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants