-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for using random agents, improvements in CollectStats #1207
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1207 +/- ##
==========================================
+ Coverage 85.25% 85.30% +0.05%
==========================================
Files 102 102
Lines 8982 9074 +92
==========================================
+ Hits 7658 7741 +83
- Misses 1324 1333 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
02ab06a
to
dcf1b2e
Compare
353e477
to
1eaf276
Compare
21c21ab
to
df6a069
Compare
@maxhuettenrauch I improved the collect-stats for action dists in 6f8648a and b0ba423, also adding tests for stats collection. FYI |
Since it's mostly an extension (apart from a minor renaming of an existing class), I'm going to merge this. Feel free to comment post-merge if there's anything to be discussed |
Added tests, renamed entries
3a1de8c
to
b0ba423
Compare
Random action agents can be useful for tests, but also as a baseline.
Also (independent change):
One thing is a bit weird in this implementation: in high level interfaces the optim_factory is obligatory. For random actions it doesn't make sense, of course, but making it optional would require changes and additional type checks in several places. @opcode81 what do you think about this - should we make it optional?
@Trinkle23897 a quick glance should be enough, nothing controversial. @opcode81 is on vacation and won't have time to review