Code cleanup #50
Code cleanup #50
Conversation
- changed some var to const to increase efficiency - closed </div> and </button> in outline.ejs and stats.ejs - put === instead of == inside of stats.js
- Removed main.css - Code inside main_node.js was a duplicate of main.js, removed
- CSS files improved
- Switching from == to ===
- Minor code improvement
- Deleted main_node.js - it was a copy of main.js
|
There are far too many different kinds of changes being put together in one PR here. |
| @@ -5,7 +5,7 @@ | |||
| "license": "MIT", | |||
| "main": "main.js", | |||
| "scripts": { | |||
| "start:server": "nodemon main_node.js", | |||
| "start:server": "nodemon main.js", | |||
There was a problem hiding this comment.
No, this is not right. The "main.js" here is the Electron one, the "main_node.js" is the one for the server. Please also restore the file.
There was a problem hiding this comment.
So the two files have diverged quite a bit. And it may be confusing later on to keep the two files in sync.
For now, can we simply do something like: Have some comments on the main.js file, pointing to which part is related to electron and which is not? It will make it easier to copy paste the contents accordingly, until we try make them in sync automatically.
There was a problem hiding this comment.
Yeah, there is some issue there. I will try to have a shared common root there so that there are no such issues.
templates/outline.ejs
Outdated
| </button> | ||
| </div> | ||
| <% if (locals.path === "/saves") { %> | ||
| <div id="content" class="content" hx-post hx-trigger="load" hx-ext="submitlocalstorage"> |
There was a problem hiding this comment.
The linting does not have the correct indentation here.
| Hearing: | ||
| <span id="hearing_value"> | ||
| <% if (locals.v_hearing) { %> <%= v_hearing %> <% } else {%> 0 <% } %> | ||
| <% if (locals.v_hearing) { %> <%= v_hearing %> |
There was a problem hiding this comment.
This style is arguably less readable than the previous one. Also all of these could be collapsed to something like
| <% if (locals.v_hearing) { %> <%= v_hearing %> | |
| <%= locals.v_hearing || 0 %> |
(I think)
|
Alright, will work on fixing it, also I'll add some documentation on |
|
Will create a new Pull Request |
Issue #45