The `VariablesInAllowedPosition` rule mutates the provided *ast.Value
which causes future validation to fails as well as altering the result
of the introspect query in gqlgen.

"VariablesInAllowedPosition" rule updates "value.ExpectedType.NonNull = false",
resulting in "ProvidedRequiredArguments" rule to have "argDef.Type.NonNull" changed on the next call.

Both ast.Value.ExpectedType and ast.VariableDefinition.Type are the pointers,
and it is easy to update values by accidence.

Therefore creating a copy, so changes in one validation rule (E.g. VariablesInAllowedPosition)
would not affect the behavior of the other rule (ProvidedRequiredArguments).

Not doing deep copy, so change should not have a big impact for memory or CPU even for large GraphQL applications.

Testing private methods, to not be confused by complex golang syntax.
(those are pure functions, so in case testing package is changed – refactoring should not be hard)

Update prelude to match graphql_spec for @deprecated directive

Stop validator mutating the provided *Schema

Conflicts:
	validator/validator_test.go - include both tests

It was possible to fix the single cause,
or to prevent accidental changes in future functions.

Assuming tests would cover future changes,
so removing additional check (that could in theory impact performance).

Also include specifiedBy in __Type

Aligns with <https://github.com/graphql/graphql-js/blob/main/src/validation/rules/OverlappingFieldsCanBeMergedRule.ts#L626-L642>.

Added tests.

docs: Fix a few typos in the README

feat: do not mark __typename field as unknown in the schema validation

…rison

Fix: argument comparison between two sets of args

Add @SpecifiedBy directive declaration

Fix for update by reference of default variable values

Signed-off-by: Steve Coffman <[email protected]>

Add release script

Revert "Add @SpecifiedBy directive declaration"

Support intermediate interfaces

https://spec.graphql.org/October2021/#sec-Schema-Introspection

fixed prelude.graphql to be correct in the latest spec

supported schema description for introspection

* update Node.js harness

* update environments

* regenerate test specs

* Fix Rule suffix

These should match the strings passed into AddRule()

* Update metadata for interface implements so covariance check works

* Adjust quoting and verbiage to match new test suite expectations

Signed-off-by: Steve Coffman <[email protected]>

* fixed to be starting indent from line 1

* regenerate test specs

* fixed UniqueVariableNames validator rule to add the same error only once

* fixed ValuesOfCorrectTypeRule test for #181

* fixed UniqueArgumentNames test for #181

* fixed SingleFieldSubscriptions tests for #181

* fixed deviations to ignore NoDeprecatedCustomRule because optional

* fixed deviations to ignore NoSchemaIntrospectionCustomRule because optional

* fixed KnownDirectives validation for #181

* fixed deviations.yml

* fixed FieldsOnCorrectType for #181

* fixed OverlappingFieldsCanBeMergedRule for #181

* fixed ProvidedRequiredArguments for #181

* fixed UniqueVariableNames validator rule to add the same error only once

* fixed UniqueArgumentNames test for #181

* fixed SingleFieldSubscriptions tests for #181

* fixed KnownDirectives validation for #181

* fixed FieldsOnCorrectType for #181

* fixed OverlappingFieldsCanBeMergedRule for #181

* fixed ProvidedRequiredArguments for #181

* fixed walk logic for directive

* fixed UniqueDirectivesPerLocation for repeatable

* fixed KnownTypeNames for #181

* fixed NoUndefinedVariables for #181

* upgrade go version

* fixed modules

* added interfaces.graphql for 14aecc0

Co-authored-by: vvakame <[email protected]>
Co-authored-by: Adam Scarr <[email protected]>
Co-authored-by: Kei Kamikawa <[email protected]>

https://github.com/graphql/graphql-spec/blob/deprecate-args/spec/Section%203%20--%20Type%20System.md#deprecated

Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.2.4 to 2.2.8.
- [Release notes](https://github.com/go-yaml/yaml/releases)
- [Commits](go-yaml/yaml@v2.2.4...v2.2.8)

---
updated-dependencies:
- dependency-name: gopkg.in/yaml.v2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…202)

* added validateTypeImplementsAncestors to validate implemented types

* added period

* fixed to make key slices

* Report definition name in validateDefinition errors

* Fix error report

* formatter: support setting space indent

* fix: change SpaceIndent to Indent

* fix: only write newline in the description if needs

* chore: update tests

Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Jason Leasure <[email protected]>

* use file embedding (Go 1.16) to embed prelude.graphql rather than using a long (and redundant) string literal

* Remove inliner.go and its //go:generate use in schema.go.  This is no longer necessary with use of //go:embed prelude.graphql

* fix bug and delete String of Int and Float

* fix bug and delete String of Int and Float

* add string

* add changes

* change module name

* change all module name

* Add helper functions and short circuit to avoid performance regression

Signed-off-by: Steve Coffman <[email protected]>

Co-authored-by: Steve Coffman <[email protected]>

* fix issue #160: validateVarType parsing numbers

* Fix typo

Signed-off-by: Steve Coffman <[email protected]>

Co-authored-by: scboffspring <[email protected]>

#220)

…or only built-in (#222)

* Report error for null values that cannot be null

* fix tests pass

Co-authored-by: Roman A. Grigorovich <[email protected]>

Normally we don't want to let you define a directive twice.* But if the
directive is builtin, and one copy of it is from your schema while the
other is from the prelude, then we have to, because the spec only says
that such directives "may" be excluded from SDL. (This happens in
practice when you generate a schema from introspection, which does
define all builtins, and your generator doesn't filter them out.) So now
we allow it, only for builtin directives.

*Fun fact: technically the spec doesn't say we shouldn't. But I think
that's an error in the spec, and it's reasonable and correct to check.
In general I think the schema validation portions of the spec are
pretty incomplete :| .

Turns out neither we (nor anyone else) were validating this, because the
spec didn't say explicitly to validate it.  So you could do
`mutation { bogus }` even if the schema has no mutation types, or worse,
any syntactically valid query if the schema is totally empty.

In graphql/graphql-spec#955 I'm adding it to the spec, and in
graphql/graphql-js#3592 someone else is adding it to graphql-js.  So we
should too, once those land!  At that point we should also likely
reimport the relevant tests, instead of the ones I wrote here, but I
figured I'd put the PR up now so folks can review the non-test parts if
you like.

Fixes #221.

* check for non enum values on validation

* add newline to end of schema_test.yml

As of Go 1.16, the same functionality is now provided by package io or
package os, and those implementations should be preferred in new code.

So replacing all usage of ioutil pkg with io & os.

* account for newline characters in block str

* fix test and simplify block string line increment logic, fixes #229

* place block str test in correct section

Co-authored-by: Ahmad Moudani <[email protected]>

This commit adds custom UnmarshalJSON implementations around the
SelectionSet type, so that it is now possible to directly deserialize an
appropriately-formed JSON object into an AST document struct.

Signed-off-by: Philip Conrad <[email protected]>

Signed-off-by: Philip Conrad <[email protected]>

Co-authored-by: Suraj Chafle <[email protected]>

Signed-off-by: Steve Coffman <[email protected]>

Signed-off-by: Steve Coffman <[email protected]>

…line number (#236)

Co-authored-by: Ahmad Moudani <[email protected]>

Signed-off-by: Steve Coffman <[email protected]>

Signed-off-by: Steve Coffman <[email protected]>

* Add basic PR CI/CD checks.

This commit adds two manual Github Actions workflows, and one automated
workflow that runs both jobs on every PR commit.

The workflows include:

 - Automated linting with golangci-lint
 - Automated `go test ./...`

Signed-off-by: Philip Conrad <[email protected]>

* Linter ignores for dot imports.

Signed-off-by: Philip Conrad <[email protected]>

* Fix linter issues with changes + ignores.

Signed-off-by: Philip Conrad <[email protected]>

* Fix prealloc linter suggestions.

Signed-off-by: Philip Conrad <[email protected]>

* Switch to `ubuntu-latest` + use GH Action for golangci-lint.

Signed-off-by: Philip Conrad <[email protected]>

* Disable MacOS tests.

Signed-off-by: Philip Conrad <[email protected]>

Signed-off-by: Philip Conrad <[email protected]>

Signed-off-by: Steve Coffman <[email protected]>

Signed-off-by: Steve Coffman <[email protected]>

Bumps [json5](https://github.com/json5/json5) from 2.2.0 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.0...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Validate directive arguments

* nits clean

* Check for pass in null explicitly

* validate enum values directive is legit

* Add tests

Signed-off-by: Steve Coffman <[email protected]>

* feat(lexer): return comment tokens

* fix(testrunner): fix error comparison in testrunner

* test(lexer): add position test for comments

* test(parser): add position tests

* feat(parser): skip comments in parsing

* feat(ast): add comment fields

* feat(formatter): implement getComment

* feat(parser): store comments in parser

* feat(ast): add Comment field for Definition

* feat(ast): implement Dumper interface for CommentGroup

* feat(parser): add comment support for schema parsing

* fix(parser): add comments to schema extensions

* test(formatter): add comments for schema test

* fix(ast,parser): treat multiline comments

* feat(formatter): format schema comments

* test(formatter): update golden

* feat(parser): implement comment parsing

* test(formatter): add query comment tests

* refactor(formatter): remove unused function

* refactor(parser): use dot import

* refactor(ast): remove unused methods

* fix: support comments before and after description

* test(parser): add test case with comments and descriptions

* fix: fix lost of comments after desription

* test(formatter): add description to scalar test case

* fix(parser): remove empty line

* fix: treat end of definition comments

* feat(formatter): emit end of definition comments

* feat(parser): treat end of file comment

* feat: add EndOfDefinitionComment to SchemaDefinition

* fix(formatter): treat schema description and comments

* feat(formatter): support end of file comments

…k.json to reduce vulnerabilities (#267)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-SEMVER-3247795

Co-authored-by: snyk-bot <[email protected]>

Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…faults (#270)

Signed-off-by: Steve Coffman <[email protected]>

* Put comments behind an option in formatter

In #263, we introduced parsing of comments, as well as support for them
in the formatter. In some cases this is surely useful, but in others
it's just bloat. (And as I describe in Khan/genqlient#282, it may even
be a problem in some cases which depended on the fact that formatting
the query didn't include comments.)

In this commit I introduce an option to control whether comments are
formatted. I set the default to false (i.e. restoring the previous
behavior if no options are set), because adding this felt to me
like a breaking change, and because it seems to me like the more common
usage. `WithComments()` restores the behavior added in #263. If others
disagree I'm happy to keep the changed default, and instead provide
`WithoutComments()`. I also added tests both ways (and for the existing
`WithIndent()` option), and checked that the `comments` tests match the
existing ones, and the `default` tests match those from `v2.6.3` (except
for the addition of a few descriptions whose omission seem to have been
a bug).

Comments are still parsed in any case, as adding new struct fields is no
problem; and they are still included in `Dump` since that seems
obviously parallel to struct fields and is more of a debugging thing.

* docs

Signed-off-by: Steve Coffman <[email protected]>

* Add WrapIfUnwrapped

Signed-off-by: Steve Coffman <[email protected]>

* Lint fixes

Signed-off-by: Steve Coffman <[email protected]>

---------

Signed-off-by: Steve Coffman <[email protected]>

* More lint

Signed-off-by: Steve Coffman <[email protected]>

* Update versions

Signed-off-by: Steve Coffman <[email protected]>

---------

Signed-off-by: Steve Coffman <[email protected]>

Signed-off-by: Steve Coffman <[email protected]>

* make *gqlerror.Error err public

* Update error.go

Signed-off-by: Steve Coffman <[email protected]>

Signed-off-by: Steve Coffman <[email protected]>

Co-authored-by: Jan Zombik <[email protected]>

Signed-off-by: Steve Coffman <[email protected]>

Bumps [get-func-name](https://github.com/chaijs/get-func-name) from 2.0.0 to 2.0.2.
- [Release notes](https://github.com/chaijs/get-func-name/releases)
- [Commits](https://github.com/chaijs/get-func-name/commits/v2.0.2)

---
updated-dependencies:
- dependency-name: get-func-name
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.6 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>