Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some documentation improvements #77

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Some documentation improvements #77

merged 1 commit into from
Jan 10, 2025

Conversation

ryanjjung
Copy link
Collaborator

@ryanjjung ryanjjung commented Jan 9, 2025

This is the result of reading through the docs files (not the inline module/class docs) and improving on language and formatting in a couple places.

Copy link
Collaborator

@rwood-moz rwood-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

common patterns with them by passing config options into the constructors for these classes.
A `Pulumi ComponentResource <https://www.pulumi.com/docs/reference/pkg/python/pulumi/#pulumi.ComponentResource>`_ is a
collection of related resources. In an effort to follow consistent patterns across infrastructure projects, the
patterns available in this module all extend a custom class called a :py:class:`tb_pulumi.ThunderbirdComponentResource`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is intended to be a link? But when viewing the file via GitHub preview it does appear as a link

https://github.com/thunderbird/pulumi/blob/c6c9e26cb58e3f9460420217435144481230a5ea/docs/getting-started.rst#id4

And it just opens to the top of this same getting-started.rst file just FYI.

After reading about RST more I'm guessing this wasn't intended to be a link and it's just that the quotes converted it to a link. I see the same for other :py:class entries elsewhere.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the thing to look up is called autodoc. The :py: bit indicates the Python domain.

If I generate the docs locally from this branch, that link looks like this:

Screenshot_20250110_111130

And the URL it points to is file:///home/rjung/workspace/thunderbird/pulumi/docs/_build/html/tb_pulumi.html#tb_pulumi.ThunderbirdComponentResource (which is a relative path in the HTML that otherwise directs to the docs domain once published).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, cool, thanks 👍

@ryanjjung ryanjjung merged commit f41aa6b into main Jan 10, 2025
3 checks passed
@ryanjjung ryanjjung deleted the documentation branch January 10, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants