Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation on quickstart #93

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Update documentation on quickstart #93

merged 1 commit into from
Jan 29, 2025

Conversation

ryanjjung
Copy link
Collaborator

This fixes a couple documentation things related to the QuickStart.

@ryanjjung ryanjjung added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 29, 2025
@ryanjjung ryanjjung self-assigned this Jan 29, 2025
Copy link
Collaborator

@radishmouse radishmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my uncertainty about telling quickstart.sh about an S3 bucket, it's 👍

@@ -77,7 +77,8 @@ Manual Setup
S3 bucket
^^^^^^^^^

.. note:: This step is optional. If you do not set up an S3 bucket, you can use Pulumi Cloud instead.
.. note:: This step is optional. If you do not set up an S3 bucket, you can use Pulumi Cloud instead by specifying
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly obvious, but: if the user does set up an S3 bucket, how do they specify it? It looks like that argument for the quickstart.sh is removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would specify it as a full URL, like s3://name-of-your-bucket

@ryanjjung ryanjjung merged commit 1183c9f into main Jan 29, 2025
3 checks passed
@ryanjjung ryanjjung deleted the quickstart-docs branch January 29, 2025 18:35
@ryanjjung ryanjjung added this to the v0.0.11 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants