Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fr and de hero images (Fixes #713) #714

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MelissaAutumn
Copy link
Member

Fixes #713

Pinging @jobisoft and @babolivier for feedback as I do not speak German, and my highschool french only gets me so far. (No rush on the feedback!)

@babolivier
Copy link
Member

babolivier commented Nov 26, 2024

French looks good to me, translations seem to match what's in Pontoon. A couple of nitpicks on the label names:

  • the translation for "Todo" is a bit awkward (it would translate to "do" rather than "to do"), "À faire" would be more fitting
  • the translation for "Upgrade" is correct, but I think "Mise à jour" would feel a tiny bit more natural

@jobisoft
Copy link
Contributor

jobisoft commented Dec 3, 2024

Referring to the text on:
https://github.com/thunderbird/thunderbird-website/blob/777264f59720df0aa4e7dc0cb3cec71b951ca6df/media/img/l10n/de/thunderbird/base/home/banner-high-res.png

The german translation "Lass uns fliegen! Es ist Zeit für Thunderbird 128." for "Let's fly! It's time for Thunderbird 128." is a literal translation, word by word. But the german translation does not seem to have the intended meaning. What are you trying to express?

  • Let's go! It is time for Thunderbird 128. -> "Lass uns loslegen! Es ist Zeit für Thunderbird 128."

@kaie : What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the hero image with additional localizations
4 participants