Migrate database implementation to SqlDelight #11
Conversation
kirillzh
force-pushed
the
zhukov/sqldelight
branch
from
db51e82 to
dc331f7
Compare
There was a problem hiding this comment.
Looks great. I'm glad to be working with SQLDelight, which I don't know as much about as I should. Also thanks for the new tests!
Two little things:
- a quick rebase should remove the need for commit 20cf213 (the one that bumps the Java version).
- I'd like to add KDocs for at least the db interface
Otherwise looks good!
|
@kirillzh I'm not sure if I have the correct Discord username for you, but I tried sending you a message there so we can chat more easily (let me know if you didn't receive anything and I just sent a message to a rando!) I also wanted to know if you had seen the Kotlin Bitcoin Tools Org. It only has 2 public repos so far, but they have similar goals to this cashu library (KMP-compatible, well documented, well tested, etc.). I have a working Unified Resources library there, which you need to read fountain QR codes as per NUT-16. This is where this library would move to if it ever becomes a bit more production-ready. Anyway just letting you know so more Kotlin devs know about it! |
Expose is a JVM only lib. SqlDelight provides KMP support out of the box. This migrates the internal db implementation to SqlDelight. Work towards resolving issue #3.
kirillzh
force-pushed
the
zhukov/sqldelight
branch
from
dc331f7 to
9748a37
Compare
Expose is a JVM only lib. SqlDelight provides KMP support out of the box.
This migrates the internal db implementation to SqlDelight.
Work towards resolving issue #3.