refactor: drop gson dependency #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use kotlinx.serialization instead of GSON to deserialize Keyset from JSON. Work towards resolving issue #3.
Open
thunderbiscuit
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
ACK b1b8e84. Thanks for the fix, I don't even know why I was still using gson when I was already depending on kotlinx.serialization-json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use kotlinx.serialization instead of GSON to deserialize Keyset from JSON.
Work towards resolving issue #3.