Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edk2-libc: Add LoongArch64 support #20

Closed
wants to merge 1 commit into from

Conversation

MarsDoge
Copy link
Member

@MarsDoge MarsDoge commented Dec 9, 2024

No description provided.

@MarsDoge
Copy link
Member Author

Test Cases: OrderedCollectionTest

  1. sh gentest.sh > input.txt
  2. OrderedCollectionTest -i input.txt -o output.txt

@MarsDoge MarsDoge changed the title StdLib: Add LoongArch64 support edk2-libc: Add LoongArch64 support Dec 10, 2024
@MarsDoge
Copy link
Member Author

MarsDoge commented Dec 10, 2024

Hi @mdkinney @jpshivakavi @bexcran ,
would you mind reviewing this PR when you get a chance? Your feedback would be greatly appreciated. Thanks!

@jpshivakavi
Copy link
Contributor

The build actions with GCC and VS tool chains are passing. It means that the changes are not breaking the existing things.

@mdkinney
Copy link
Member

mdkinney commented Dec 10, 2024

Do you want to add LOONGARCG to the GitHub actions to verify build? May require adding a build step in GCC build agent to just build StdLib.

@jpshivakavi
Copy link
Contributor

@mdkinney it's a good suggestion, I will look into adding build action for building the stdlib - with MSFT Visual Studio, GCC and LoongArch64.

@MarsDoge
Copy link
Member Author

Regarding Python interpreter support under AppPkg, it appears that the ARM platform is currently unsupported.
While I have verified the Lua interpreter on LoongArch, Python 3.6.8 requires additional SourceCode support, similar to ARM. Therefore, I suggest we first consider adding CI for the StdLib* build on the LoongArch platform.
This approach should not only apply to LoongArch CI but also be relevant for ARM CI setup.
Do you have any other suggestions or alternatives?

@jpshivakavi
Copy link
Contributor

@MarsDoge Python 3.6.8 requires additional support for LoongArch64. That can be taken up as a separate effort. I am also of the pinion to setup a github action for StdLib covering the LoongArch64. @mdkinney mike is also suggesting the same.

@mdkinney is it ok if we setup a separate build action for the StdLib covering the X64, ARM and LoongArch64 with VS & GCC compilers for X64, and GCC compiler for ARM and LoongArch64. Let me know if you have any other thoughts.

@MarsDoge
Copy link
Member Author

MarsDoge commented Dec 11, 2024

I tried to build a CI matrix to see if I could give you some reference.
You are welcome to correct me.: edk2-libc: add github workflow to build app efi with GCC

@mdkinney
Copy link
Member

Yes. An independent CI job for StdLib sounds like a good idea since the support for StdLib and Python are not the same today

@MarsDoge MarsDoge force-pushed the LoongArch branch 2 times, most recently from 0e0fe0f to 067660f Compare December 13, 2024 03:18
@MarsDoge
Copy link
Member Author

@jpshivakavi Hello, it seems that there is a package (python3-distutils) issue with the current CI.
Please check and help to re-trigger CI, Tks !

@jpshivakavi
Copy link
Contributor

@MarsDoge I have raised a pull request to fix the GCC build actions issue: #23

@MarsDoge
Copy link
Member Author

@MarsDoge I have raised a pull request to fix the GCC build actions issue: #23

Before using containers to build CI environments, I also thought that fixed compiler versions were the only way.

@jpshivakavi
Copy link
Contributor

@MarsDoge I believe the PR 21 contains all the changes in PR 20 and this may not be required to be merged if the PR 21 is processed. I think this PR can be closed without merging. Let me know if you have any concerns or questions.

@MarsDoge
Copy link
Member Author

MarsDoge commented Jan 9, 2025

That's it, I will close this PR and only keep #21 open.

@MarsDoge MarsDoge closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants