Fix hii opcode handle leak #744
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a bunch of warnings similar to:
Ampere/JadePkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c:446:15:
error: 'Status' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
EFI_STATUS Status;
^~~~~~
cc1: all warnings being treated as errors
And a single warning about MemorySize variable:
SmbiosPlatformDxe/Type19/PlatformMemoryArrayMappedAddressFunction.c:131:12:
error: 'MemorySize' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
if (MemorySize != 0) {
^
cc1: all warnings being treated as errors
Signed-off-by: Mike Maslenkin <[email protected]>
This patch fixes the following warnings:
RootComplexConfigDxe/RootComplexConfigDxe.c: In function 'RouteConfig':
RootComplexConfigDxe/RootComplexConfigDxe.c:341:12: error: 'VarStoreConfig'
may be used uninitialized in this function [-Werror=maybe-uninitialized]
Status = HiiConfigRouting->ConfigToBlock (
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
HiiConfigRouting,
~~~~~~~~~~~~~~~~~
Configuration,
~~~~~~~~~~~~~~
(UINT8 *)VarStoreConfig,
~~~~~~~~~~~~~~~~~~~~~~~~
&BufferSize,
~~~~~~~~~~~~
Progress
~~~~~~~~
);
~
SystemFirmwareUpdateDxe/SystemFirmwareUpdateDxe.c:
In function 'SystemFirmwareUpdateSetVariable':
SystemFirmwareUpdateDxe/SystemFirmwareUpdateDxe.c:269:25:
error: 'SubId' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
mUpdateFWSubId = SubId;
~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
cc1: all warnings being treated as errors
Signed-off-by: Mike Maslenkin <[email protected]>
Signed-off-by: Mike Maslenkin <[email protected]>
ghbaccount
requested review from
nhivp,
bexcran and
chuongtranle
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually this was a part of findings fixed by tianocore/edk2#6424
But when I tried to build /Ampere/JadePkg/Jade.dsc I've got a bunch of other [-Werror=maybe-uninitialized] warnings.