test_locate_tools: Make test_FindInf2CatToolInWinSdk() results consistent #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javagedes
approved these changes
Sep 30, 2024
makubacki
force-pushed
the
mock_localtoolstest_func_for_consistent_results
branch
from
54ec092
to
751cab9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #647 +/- ##
==========================================
- Coverage 81.43% 81.31% -0.13%
==========================================
Files 56 45 -11
Lines 7514 7486 -28
==========================================
- Hits 6119 6087 -32
- Misses 1395 1399 +4 ☔ View full report in Codecov by Sentry. |
…tent Currently, this function depends on finding the actual inf2cat.exe tool which is dependent on the user's system. Instead mock the dependencies so the function logic is excercised but with consistent dependency values. Signed-off-by: Michael Kubacki <[email protected]>
Javagedes
force-pushed
the
mock_localtoolstest_func_for_consistent_results
branch
from
751cab9
to
e44f743
Compare
Javagedes
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this function depends on finding the actual inf2cat.exe tool which is dependent on the user's system. Instead mock the dependencies so the function logic is excercised but with consistent dependency values.