Fix UEFI Variable Fetching on Linux #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apop5
approved these changes
Oct 18, 2024
The UEFI variable fetching on Linux was broken, it was reading the attributes as part of the data, not correctly skipping over the attributes and fetching the data. For Linux, the value read is a UINT32 Attributes + Variable Length Data. This change has been tested to fix that but reading (and ignoring but logging an error if the attributes aren't 7, as ConfigEditor expects) the attributes and then fetching the data past that.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #655 +/- ##
==========================================
- Coverage 81.43% 81.43% -0.01%
==========================================
Files 56 45 -11
Lines 7514 7492 -22
==========================================
- Hits 6119 6101 -18
+ Misses 1395 1391 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UEFI variable fetching on Linux was broken, it was reading the attributes as part of the data, not correctly skipping over the attributes and fetching the data. For Linux, the value read is a UINT32 Attributes + Variable Length Data.
This change has been tested to fix that but reading (and current ignoring but logging an error if the attributes aren't 7, as ConfigEditor expects) the attributes and then fetching the data past that.