RedfishClientPkg: fix memory leak

The structure instance retunred by ToStructure() must be deallocated properly. Cc: Abner Chang <[email protected]> Cc: Igor Kulchytskyy <[email protected]> Cc: Nickle Wang <[email protected]> Signed-off-by: Mike Maslenkin <[email protected]> Reviewed-by: Abner Chang <[email protected]> Reviewed-by: Nickle Wang <[email protected]>
tianocore · Mar 14, 2024 · 0499a77 · 0499a77
1 parent 3077cab
commit 0499a77
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/...edfishResourceIdentifyLibComputerSystem/v1_5_0/RedfishResourceIdentifyLibComputerSystem.c b/...edfishResourceIdentifyLibComputerSystem/v1_5_0/RedfishResourceIdentifyLibComputerSystem.c
@@ -70,19 +70,20 @@ RedfishIdentifyResource (
   ComputerSystemCs = ComputerSystem->ComputerSystem;
 
   if (IS_EMPTY_STRING (ComputerSystemCs->UUID)) {
-    return FALSE;
+    Status = EFI_NOT_FOUND;
+    goto ON_RELEASE;
   }
 
   Status = AsciiStrToGuid (ComputerSystemCs->UUID, &ResourceUuid);
   if (EFI_ERROR (Status)) {
     DEBUG ((DEBUG_ERROR, "%a, fail to get resource UUID: %r\n", __func__, Status));
-    return FALSE;
+    goto ON_RELEASE;
   }
 
   Status = NetLibGetSystemGuid (&SystemUuid);
   if (EFI_ERROR (Status)) {
     DEBUG ((DEBUG_ERROR, "%a, fail to get system UUID from SMBIOS: %r\n", __func__, Status));
-    return FALSE;
+    goto ON_RELEASE;
   }
 
   DEBUG ((REDFISH_DEBUG_TRACE, "%a, Identify: System: %g Resource: %g\n", __func__, &SystemUuid, &ResourceUuid));
@@ -92,6 +93,8 @@ RedfishIdentifyResource (
     Status = EFI_UNSUPPORTED;
   }
 
+ON_RELEASE:
+
   mJsonStructProtocol->DestoryStructure (
                          mJsonStructProtocol,
                          (EFI_REST_JSON_STRUCTURE_HEADER *)ComputerSystem