Skip to content

Commit

Permalink
RedfishClientPkg: use Json value from a function argument
Browse files Browse the repository at this point in the history
This patch replaces value Private->Json with Json used as second argument
for RedfishIdentifyResource(). Currently Json argument is not used at all
and the pattern for caller side is:
  Status = RedfishIdentifyResourceCommon (Private, Private->Json);

So in scope of RedfishIdentifyResourceCommon Json actually is the same
value as Private->Json. Let's make code a bit cleaner.

Cc: Abner Chang <[email protected]>
Cc: Nickle Wang <[email protected]>
Cc: Igor Kulchytskyy <[email protected]>
Signed-off-by: Mike Maslenkin <[email protected]>
Reviewed-by: Abner Chang <[email protected]>
Reviewed-by: Nickle Wang <[email protected]>
  • Loading branch information
ghbaccount committed Feb 23, 2024
1 parent ad5834a commit 34d0ec6
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ RedfishIdentifyResourceCommon (
EFI_STRING EndOfChar;
REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList;

Supported = RedfishIdentifyResource (Private->Uri, Private->Json);
Supported = RedfishIdentifyResource (Private->Uri, Json);
if (Supported) {
Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList);
if (EFI_ERROR (Status)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@ RedfishIdentifyResourceCommon (
{
BOOLEAN Supported;

Supported = RedfishIdentifyResource (Private->Uri, Private->Json);
Supported = RedfishIdentifyResource (Private->Uri, Json);
if (Supported) {
return EFI_SUCCESS;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,7 @@ RedfishIdentifyResourceCommon (
EFI_STRING EndOfChar;
REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList;

Supported = RedfishIdentifyResource (Private->Uri, Private->Json);
Supported = RedfishIdentifyResource (Private->Uri, Json);
if (Supported) {
Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList);
if (EFI_ERROR (Status)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1718,7 +1718,7 @@ RedfishIdentifyResourceCommon (
EFI_STRING EndOfChar;
REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList;

Supported = RedfishIdentifyResource (Private->Uri, Private->Json);
Supported = RedfishIdentifyResource (Private->Uri, Json);
if (Supported) {
Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList);
if (EFI_ERROR (Status)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2516,7 +2516,7 @@ RedfishIdentifyResourceCommon (
EFI_STRING EndOfChar;
REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST ConfigLangList;

Supported = RedfishIdentifyResource (Private->Uri, Private->Json);
Supported = RedfishIdentifyResource (Private->Uri, Json);
if (Supported) {
Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigLangList);
if (EFI_ERROR (Status)) {
Expand Down

0 comments on commit 34d0ec6

Please sign in to comment.