Feature/new-flat-config #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove all targets except one * Remove old format Eslint config * Remove AirBNB rules (used in v2, reverting to extending XO as done in v1)
…w flat config format. Needs: `npm install --force` to accept outdated peer dependency of `eslint-plugin-istanbul` see: istanbuljs/eslint-plugin-istanbul#17
(They still fail)
PS needs: `npx patch-package eslint-plugin-typescript-sort-keys --exclude` to include `package.json` changes.
* Unit tests * Cypress * Typescript definition files * Node files
Allow `console` in Node Widen Cypress glob pattern
…nit tests also, not just Cypress. (It is fine to use, but should not be committed.)
TheHaff
approved these changes
Sep 12, 2023
With updated and stricter tests, outdated plugin no longer required.
As we do not support untyped linting anymore anyway
* Enables JSX prop sorting too * Removes three packages (and a patch)
For cases where it is needed `@ts-expect-error` should be used with an explanation of why (that is allowed).
TheHaff
approved these changes
Sep 19, 2023
MathiasTim
approved these changes
Sep 20, 2023
andymartinwork
approved these changes
Sep 20, 2023
enjikaka
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should now be ready for review!
Package is currently not published yet, so I have only been testing with
yarn link, I plan on publishing internally (to Nexus) next, then we can wait with open sourcing (again) until the SDK goes out.The changes:
.eslintrc.js/.eslintignoresetup to new flat format:eslint.config.jseslint-plugin-jsx-a11yandconfusing-browser-globalseslint-plugin-istanbulStill TBD:
warntoerror? (can then overridden in importing packages, but not sure how far we want to go?)^now)