Refactor ShakaPlayer initialization from providing the media element …

…in the constructor to calling the attach method. Resolves #38 (#39)
tidal-music · Feb 6, 2024 · ec325c5 · ec325c5
1 parent 9e23715
commit ec325c5
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/player/src/player/shakaPlayer.ts b/packages/player/src/player/shakaPlayer.ts
@@ -357,7 +357,9 @@ export default class ShakaPlayer extends BasePlayer {
   async #createShakaPlayer(mediaEl: HTMLMediaElement) {
     this.debugLog('createShakaPlayer', mediaEl);
 
-    const player = new shaka.Player(mediaEl);
+    const player = new shaka.Player();
+
+    await player.attach(mediaEl);
 
     registerStalls(mediaEl);
     registerAdaptations(player);