Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Player] Remove playback progress event #120

Closed

Conversation

enjikaka
Copy link
Member

@enjikaka enjikaka commented May 6, 2024

The playback progress event has been used for the "Recently Playing" module on the home page. Our API now uses the playlog events instead to derive that information. So this is redundant. Removing!

Branched from #92, #91 and #92 needs to be merged first.

@enjikaka enjikaka self-assigned this May 6, 2024
@osmestad
Copy link
Contributor

osmestad commented May 7, 2024

I assume it is not needed for Podcast progress anymore either then?

@enjikaka
Copy link
Member Author

enjikaka commented May 8, 2024

I assume it is not needed for Podcast progress anymore either then?

Correct!

@enjikaka enjikaka closed this May 13, 2024
@enjikaka
Copy link
Member Author

We're going to wait a little bit more before doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants