Removed internal api from auth example #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- addresses #119 - minor type fixes in shared
osmestad
approved these changes
May 6, 2024
andymartinwork
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we got a report (#119) that the authroization code example (formerly called "login redirect") doesn't work I started digging. We found out that in the example code I used an internal api to get e.g. the userId.
I changed the example code to use the same endpoint (search) to demonstrate the token is working.
Alongside we are also extracting the userId from the access token, which is only present in this flow and not at e.g. client credentials.
Also fixed some minor type issues in the js doc comments in
shared.js