-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haff/change dispatch to send #46
Merged
TheHaff
merged 2 commits into
haff/vitest-coverage-gha
from
haff/change-dispatch-to-send
Feb 22, 2024
Merged
Haff/change dispatch to send #46
TheHaff
merged 2 commits into
haff/vitest-coverage-gha
from
haff/change-dispatch-to-send
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report for Auth (./packages/auth)
File CoverageNo changed files found. |
Coverage Report for Common (./packages/common)
File CoverageNo changed files found. |
Coverage Report for Event Producer (./packages/event-producer)
File Coverage
|
Coverage Report for Player Web Components (./packages/player-web-components)
File CoverageNo changed files found. |
Coverage Report for True Time (./packages/true-time)
File CoverageNo changed files found. |
osmestad
approved these changes
Feb 15, 2024
MathiasTim
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this branch depending on the vitest one? Otherwise LGTM
TheHaff
added a commit
that referenced
this pull request
Feb 27, 2024
* rename dispatchEvent to sendEvent * bump version for event-producer change
osmestad
pushed a commit
that referenced
this pull request
Feb 28, 2024
TheHaff
added a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially lobbied for dispatch+submit over send+submit since i found the words to similar. With this we should be fully aligned with the speck 🥓