Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haff/change dispatch to send #46

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

TheHaff
Copy link
Contributor

@TheHaff TheHaff commented Feb 14, 2024

I initially lobbied for dispatch+submit over send+submit since i found the words to similar. With this we should be fully aligned with the speck 🥓

@TheHaff TheHaff requested review from MathiasTim and a team as code owners February 14, 2024 15:51
@TheHaff TheHaff changed the base branch from main to haff/vitest-coverage-gha February 14, 2024 15:51
Copy link

Coverage Report for Auth (./packages/auth)

Status Category Percentage Covered / Total
🟢 Lines 69.41% / 69% 1110 / 1599
🟢 Statements 69.41% / 69% 1110 / 1599
🟢 Functions 73.77% / 73% 45 / 61
🟢 Branches 92.45% / 80% 147 / 159
File CoverageNo changed files found.
Generated in workflow #119

Copy link

Coverage Report for Common (./packages/common)

Status Category Percentage Covered / Total
🟢 Lines 50.35% / 50% 70 / 139
🟢 Statements 50.35% / 50% 70 / 139
🟢 Functions 37.5% / 37% 3 / 8
🟢 Branches 42.85% / 42% 3 / 7
File CoverageNo changed files found.
Generated in workflow #119

Copy link

Coverage Report for Event Producer (./packages/event-producer)

Status Category Percentage Covered / Total
🟢 Lines 87.33% / 80% 807 / 924
🟢 Statements 87.33% / 80% 807 / 924
🟢 Functions 82.6% / 80% 38 / 46
🟢 Branches 84.88% / 80% 73 / 86
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/event-producer/src/index.ts 77.61% 100% 66.66% 77.61% 24-38
packages/event-producer/src/types.ts 0% 0% 0% 0% 1-41
Generated in workflow #119

Copy link

Coverage Report for Player Web Components (./packages/player-web-components)

Status Category Percentage Covered / Total
🟢 Lines 8.81% / 8% 68 / 771
🟢 Statements 8.81% / 8% 68 / 771
🟢 Functions 30% / 30% 3 / 10
🟢 Branches 66.66% / 66% 18 / 27
File CoverageNo changed files found.
Generated in workflow #119

Copy link

Coverage Report for True Time (./packages/true-time)

Status Category Percentage Covered / Total
🟢 Lines 94.52% / 80% 69 / 73
🟢 Statements 94.52% / 80% 69 / 73
🟢 Functions 100% / 80% 5 / 5
🟢 Branches 88.23% / 80% 15 / 17
File CoverageNo changed files found.
Generated in workflow #119

Copy link
Contributor

@MathiasTim MathiasTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this branch depending on the vitest one? Otherwise LGTM

@TheHaff TheHaff merged commit bde68b9 into haff/vitest-coverage-gha Feb 22, 2024
@TheHaff TheHaff deleted the haff/change-dispatch-to-send branch February 22, 2024 13:13
TheHaff added a commit that referenced this pull request Feb 27, 2024
* rename dispatchEvent to sendEvent

* bump version for event-producer change
osmestad pushed a commit that referenced this pull request Feb 28, 2024
* rename dispatchEvent to sendEvent

* bump version for event-producer change
TheHaff added a commit that referenced this pull request Feb 28, 2024
* main:
  Refactoring of the IndexedDB layer for the local reducer (#50)
  Haff/change dispatch to send (#46) (#61)
  Add FOSSA scans (#57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants