Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try adding Cypress back #82

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Try adding Cypress back #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df0c2dc
Add Cypress back
enjikaka Mar 5, 2024
d06d5a3
force run on pr
enjikaka Mar 5, 2024
21878cb
Trigger change in pkg
enjikaka Mar 5, 2024
58b82a7
Add back step "Set up Cypress binary cache"
enjikaka Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/disabled-workflows/cypress.yml → .github/workflows/cypress.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
- packages/true-time/**
- packages/player/**
pull_request:
branches: [ "main"]
branches: [ "main" ]
paths:
- packages/true-time/**
- packages/player/**
Expand All @@ -26,7 +26,6 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
- uses: ./.github/actions/setup
- uses: ./.github/actions/build-projects
- name: Prepare test user for player tests
id: json
run: |
Expand All @@ -38,6 +37,11 @@ jobs:
echo "encoded=\"$encoded_json\"" >> $GITHUB_OUTPUT
env:
TEST_USER: ${{ secrets.PLAYER_TEST_USER }}
- name: Set up Cypress binary cache
uses: actions/cache@v4
with:
path: ~/.cache/Cypress
key: ${{ runner.os }}-cypress-${{ hashFiles('pnpm-lock.yaml') }}
- name: Cypress run
uses: cypress-io/github-action@v6
env:
Expand Down
2 changes: 1 addition & 1 deletion packages/player/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ To load TIDAL Player into a project locally without publishing to npm; using `pn

1. Open the package.json in the project. (in the case of webclient, the root one)
2. Add or edit a `"resolutions"` property on the top level. (this is an object)
3. Add an entry for @tidal-music/player like so: `"@tidal-music/player": "file:/Users/yourusername/dev/tidal-sdk-web/packages/player"`
3. Add an entry for @tidal-music/player like so: `"@tidal-music/player": "file:/Users/<your-username>/dev/tidal-sdk-web/packages/player"`
4. Run `npm/yarn/pnpm install` in your destination project.

!! Remove the entry in `"resolution"` and run `npm/yarn/pnpm install` again when you are done testing to have the NPM version of the package load instead.
Expand Down
Loading