Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haff/ep dedupe #88

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Haff/ep dedupe #88

merged 4 commits into from
Mar 15, 2024

Conversation

TheHaff
Copy link
Contributor

@TheHaff TheHaff commented Mar 14, 2024

We're seeing some issues in prod where the queue is loaded with duplicate ids in production. This is just fixing the symptom while i dig deeper into the real issue.

This pull request mainly includes changes to the event-producer package to handle duplicate event ids. The most significant change is the addition of a new error handling block in the submitEvents function to deduplicate the event queue if an error due to duplicate event ids is received from AWS Simple Queue Service. A new test case has also been added to validate this behavior.

@TheHaff TheHaff requested a review from a team March 14, 2024 21:27
packages/event-producer/src/index.ts Outdated Show resolved Hide resolved
packages/event-producer/src/submit/submit.ts Outdated Show resolved Hide resolved
@TheHaff TheHaff merged commit e62bf67 into main Mar 15, 2024
4 checks passed
@TheHaff TheHaff deleted the haff/ep-dedupe branch March 15, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants