CI on tidal-listener execute on changes only #1114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Therefore it does not make sense to me to run the full CI (which works towards a packaged release, I think) on every change in Tidal or tidal-link. If I'm wrong, feel free to just close this :)
tidal-listener depends on Tidal, so technically it makes sense to run the listener CI jobs if something in the root folder change.
the fact that the listener is currently not working is a different topic :)
it deserves some true love
|
@ndr-brt From this point of view, it certainly does make sense to keep the build-listener active. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand tidal-listener is not used in Tidal or tidal-link itself and currently a bit broken as mentioned in #1092.
Therefore it does not make sense to me to run the full CI (which works towards a packaged release, I think) on every change in Tidal or tidal-link. If I'm wrong, feel free to just close this :)