top level '|' #1128
Merged
top level '|' #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Could you test by comparing the output of e.g. |
|
Added the test and it suceeded. Would be so nice if this is really stable. :) Having to put '|' in brackets was one of the first things I thought feel weird, when I started using Tidal. Good to be able to help! |
|
Super thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #980. So far implemented '|' only. I want to make sure I am on the right track. @polymorphicengine, if you would be so kind to take a look :)
I didn't come up with a good way to test, other than (not) throwing exceptions.
It works and sounds good in the Tidal repl.