Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New app to display WeatherSTEM data #2181

Merged
merged 4 commits into from
Jan 11, 2024
Merged

New app to display WeatherSTEM data #2181

merged 4 commits into from
Jan 11, 2024

Conversation

jflood937
Copy link
Contributor

Description

This is a new application to display current conditions provided by the WeatherSTEM API. Free registration with WeatherStem is required to aquire an api token. This allows current weather conditions to be displayed for a nearby weather station, or a favorite location users may want to monitor.

weatherstem

Copilot

copilot:all

@jflood937 jflood937 requested a review from matslina as a code owner January 6, 2024 23:02
@tidbyt
Copy link

tidbyt bot commented Jan 6, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of http.star requires review
Original Author The original author matches the PR author

Previews

apps/weatherstem/weatherstem.star:

@tidbyt-bot
Copy link

tidbyt-bot commented Jan 6, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@jflood937
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@matslina matslina merged commit 000fe57 into tidbyt:main Jan 11, 2024
2 checks passed
@matslina
Copy link
Contributor

Would be great if the app could display a default graphic showing users what it'll look like once it's set up. That way we can show previews in the mobile app, and folks can get a sense of if it's worth the effort of going out to get their own API keys and so on.

@tidbyt tidbyt locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants