Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexticker: fix rendering of 0.0x% #2913

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Denton-L
Copy link
Contributor

@Denton-L Denton-L commented Jan 8, 2025

Any number that's 0.0x%, for example 0.09%, ends up rendering out as 0.9%. Fix this by using the humanize package's float() to do the hard work for us.

@Denton-L Denton-L requested a review from matslina as a code owner January 8, 2025 17:34
@tidbyt
Copy link

tidbyt bot commented Jan 8, 2025

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of animation.star requires review
🟡 Original Author The original author (M0ntyP) does not match the PR author (Denton-L)

Any number that's 0.0x%, for example 0.09%, ends up rendering out as
`0.9%`. Fix this by using the humanize package's float() to do the hard
work for us.

While we're at it, make the pixlet liner happy by removing an unused
package.
@Denton-L
Copy link
Contributor Author

@M0ntyP, do you mind taking a look at this please?

@M0ntyP
Copy link
Contributor

M0ntyP commented Jan 11, 2025

All good with me, thanks for the cleaning up my terrible code @Denton-L 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants