Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API links to fix app loading #2924

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Update API links to fix app loading #2924

wants to merge 17 commits into from

Conversation

kwinke
Copy link
Contributor

@kwinke kwinke commented Jan 30, 2025

KEXP changed their API links for json, updated these to work correctly. Revered other commit changes as work-in-progress back to originally submitted/approved PR

@kwinke kwinke requested a review from matslina as a code owner January 30, 2025 00:02
@tidbyt
Copy link

tidbyt bot commented Jan 30, 2025

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
🟡 App Dir File '.gitignore' is not below apps/
🟡 Modules Usage of http.star requires review
🟡 Original Author The original author (betterengineering) does not match the PR author (kwinke)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant