Expose widget frame count #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pixlet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Saw this issue asking for a way to get the frame count for an Animation or Marquee widget tidbyt#823 Looks like that's defined for all widgets (and is 1 in case it's not animated). This just updates the template for the render module to expose it as a readonly method, following the way size() is available for Text widgets. Added test cases. Also checked that it gives a sensible answer for marquees in particular, which gets longer as the text gets longer.
dinosaursrarr
force-pushed
the
framecount
branch
from
5215cda
to
f7c5bfb
Compare
betterengineering
approved these changes
Jul 31, 2023
dinosaursrarr
added a commit
to dinosaursrarr/tidbyt.dev
that referenced
this pull request
Apr 27, 2024
Realised I had a few PRs on that updated docs on the main repo, but not here where more people will see them: - tidbyt/pixlet#826 - tidbyt/pixlet#827 - tidbyt/pixlet#853
rohansingh
pushed a commit
to tidbyt/tidbyt.dev
that referenced
this pull request
May 15, 2024
Realised I had a few PRs on that updated docs on the main repo, but not here where more people will see them: - tidbyt/pixlet#826 - tidbyt/pixlet#827 - tidbyt/pixlet#853
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this issue asking for a way to get the frame count for an Animation or Marquee widget #823
Looks like that's defined for all widgets (and is 1 in case it's not animated). This just updates the template for the render module to expose it as a readonly method, following the way size() is available for Text widgets.
Added test cases. Also checked that it gives a sensible answer for marquees in particular, which gets longer as the text gets longer.