-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing updates after inactivity #121
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e596b8a
update snapshots for new error format
topepo 25e6fdc
fix argument name
topepo 0290bc7
update snapshots
topepo 6921489
add dev lme4 based on https://github.com/lme4/lme4/issues/758
topepo 4e4ae2c
snapshot update
topepo b498e6f
lme4 skips
topepo f6b5adc
rf snapshot update
topepo f9fe244
update snaps for `test-recipes-nnmf_sparse.R`
hfrick 63aceaf
update snaps for `test-sparse-glmnet.R`
hfrick e947f6f
update snap for `test-survival-tune-sa.R`
hfrick dd0153a
account for diff between CRAN and dev version
hfrick 8241bb3
styling of argument in warning changed
hfrick 611ff0b
update snap for `test-survival-augment.R`
hfrick a9617c8
more matrix related skips
topepo 0978b75
use current, not future, version for `Matrix`
hfrick 2fcdd88
first check for `Matrix` version, then `lme4` version
hfrick 9285297
use CRAN version of `lme4`
hfrick 4f5c396
fix version number
hfrick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,20 @@ | ||
# error traps | ||
|
||
Code | ||
poisson_reg(penalty = 0.1) %>% set_engine("glmnet") %>% fit(mpg ~ ., data = mtcars[ | ||
-(1:4), ]) %>% predict(mtcars[-(1:4), ], penalty = 0:1) | ||
Error <rlang_error> | ||
`penalty` should be a single numeric value. `multi_predict()` can be used to get multiple predictions per row of data. | ||
|
||
--- | ||
# model errors on missing penalty value | ||
|
||
Code | ||
poisson_reg() %>% set_engine("glmnet") %>% fit(mpg ~ ., data = mtcars[-(1:4), ]) | ||
Error <rlang_error> | ||
For the glmnet engine, `penalty` must be a single number (or a value of `tune()`). | ||
Condition | ||
Error in `.check_glmnet_penalty_fit()`: | ||
! For the glmnet engine, `penalty` must be a single number (or a value of `tune()`). | ||
* There are 0 values for `penalty`. | ||
* To try multiple values for total regularization, use the tune package. | ||
* To predict multiple penalties, use `multi_predict()` | ||
|
||
# predict() errors with multiple penalty values | ||
|
||
Code | ||
poisson_reg(penalty = 0.1) %>% set_engine("glmnet") %>% fit(mpg ~ ., data = mtcars[ | ||
-(1:4), ]) %>% predict(mtcars[-(1:4), ], penalty = 0:1) | ||
Condition | ||
Error in `.check_glmnet_penalty_predict()`: | ||
! `penalty` should be a single numeric value. `multi_predict()` can be used to get multiple predictions per row of data. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thought re: new
call
output.