strings_as_factors in recipe #706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for this contribution @smingerson! 🙌 As you know from #331 this is something we definitely want implemented. There are likely going to be some changes that either we add here to your PR or that we talk about with you; we have various folks going on vacation so I wanted to make sure we touched base before your PR got too old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #331.
As mentioned in #287, this is important to be able to control how a recipe behaves when used within a workflow -- as far as I can tell, it is impossible to change it from
strings_as_factors=TRUE, even using sketchy methods like namespace modification.Let me know what changes are needed.