Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change row indexing/subsetting to preserve Surv objects #444

Merged
merged 8 commits into from
Aug 14, 2023
Merged

Conversation

topepo
Copy link
Member

@topepo topepo commented Aug 3, 2023

See #443 for details.

Keep as draft PR so that we can decide how to proceed and if the row name changes are acceptable.

Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally in support of this!

R/rsplit.R Outdated Show resolved Hide resolved
@topepo topepo marked this pull request as ready for review August 4, 2023 12:10
@hfrick hfrick merged commit a6b5288 into main Aug 14, 2023
12 checks passed
@hfrick hfrick deleted the binding-surv branch August 14, 2023 12:25
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants