-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New subclasses and inner_split()
methods for validation sets
#489
Conversation
inner_split()
methods for validation setsinner_split()
methods for validation sets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup yup yup yup
I'm happy to add a method for
val_time_split
to support the usage of the deprecatedvalidation_time_split()
if we think it's necessary.
I'd say we not do so. :)
Co-authored-by: Simon P. Couch <[email protected]>
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This PR adds
inner_split()
methods for therset
s coming fromvalidation_set()
. Thosersets
can result from thegroup
andtime
variants ofinitial_validation_split()
.To be able to tell where they are coming from, this PR also adds subclasses for the
group
andtime
variant to the output ofvalidation_set()
: therset
objects and thersplit
objects within thoserset
s.I'm looking for a second opinion on the naming of the
rsplit
subclasses for thetime
variant.The interfaces and the original (and deprecated) approach via
validation_split()
put thetime
neither as a prefix nor a suffix but rather inside the more general name:initial_time_split()
,initial_validation_time_split()
,validation_time_split()
, andval_time_split
.I don't think we are going to touch the naming of the interfaces but we could touch the naming convention for the
rsplit
class. I've broken with that particular pattern of placingtime
and instead aligned with the pattern forgroup
, i.e., used it as a prefix. Could be good, could be bad, could actually not matter much.The only place I think it'll matter is here and I'm happy to add a method for
val_time_split
to support the usage of the deprecatedvalidation_time_split()
if we think it's necessary.Edit: this search suggests that we don't dispatch on that class elsewhere so it should only matter here.