Changes for #962

tidymodels · Nov 13, 2024 · 420ccbb · 420ccbb
1 parent f85eac9
commit 420ccbb
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 7 deletions.
diff --git a/R/tune_bayes.R b/R/tune_bayes.R
@@ -531,7 +531,12 @@ create_initial_set <- function(param, n = NULL, checks) {
   if (any(checks == "bayes")) {
     check_bayes_initial_size(nrow(param), n)
   }
-  dials::grid_space_filling(param, size = n)
+  if (n == 1) {
+    res <- dials::grid_random(param, size = n)
+  } else {
+    res <- dials::grid_space_filling(param, size = n)
+  }
+  res
 }
 
 check_iter <- function(iter, call) {

diff --git a/tests/testthat/_snaps/bayes.md b/tests/testthat/_snaps/bayes.md
@@ -393,12 +393,12 @@
     Message
       x Fold1: preprocessor 1/1:
         Error in `step_spline_b()`:
-        Caused by error in `spline_msg()`:
-        ! Error in if (df < 0)  : missing value where TRUE/FALSE needed
+        Caused by error in `prep()`:
+        ! `deg_free` must be a whole number, not a numeric `NA`.
       x Fold2: preprocessor 1/1:
         Error in `step_spline_b()`:
-        Caused by error in `spline_msg()`:
-        ! Error in if (df < 0)  : missing value where TRUE/FALSE needed
+        Caused by error in `prep()`:
+        ! `deg_free` must be a whole number, not a numeric `NA`.
     Condition
       Warning:
       All models failed. Run `show_notes(.Last.tune.result)` for more information.
@@ -415,10 +415,10 @@
     Message
       x Fold1: preprocessor 1/1:
         Error in `get_all_predictors()`:
-        ! The following predictors were not found in `data`: 'z'.
+        ! The following predictor was not found in `data`: "z".
       x Fold2: preprocessor 1/1:
         Error in `get_all_predictors()`:
-        ! The following predictors were not found in `data`: 'z'.
+        ! The following predictor was not found in `data`: "z".
     Condition
       Warning:
       All models failed. Run `show_notes(.Last.tune.result)` for more information.

diff --git a/tests/testthat/test-bayes.R b/tests/testthat/test-bayes.R
@@ -611,3 +611,19 @@ test_that("tune_bayes() output for `iter` edge cases (#721)", {
     tune_bayes(wf, boots, iter = NULL)
   )
 })
+
+test_that("1-point grid (#962)", {
+  skip_if_not_installed("dials", minimum_version = "1.3.0")
+
+  expect_silent({
+    set.seed(1)
+    grid <- tune:::create_initial_set(
+      dials::parameters(dials::penalty(), dials::deg_free()),
+      n = 1,
+      checks = "none"
+    )
+  })
+  expect_equal(nrow(grid), 1L)
+})
+
+