Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(common): remove "launch_hw_monitor" param in hesai_*.launch.xml #381

Merged
merged 1 commit into from
Jan 30, 2025
Merged

chore(common): remove "launch_hw_monitor" param in hesai_*.launch.xml #381

merged 1 commit into from
Jan 30, 2025
+0 −6

Conversation

Autumn60
Copy link
Contributor

With #360, launch_hw_monitor param is no longer available.

shmpwk
shmpwk approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit c5d3aa4 into tier4/universe Jan 30, 2025
9 of 10 checks passed
@shmpwk shmpwk deleted the chore/common/remove_unnecessary_params branch January 30, 2025 11:30
@Autumn60 Autumn60 mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmpwk shmpwk shmpwk approved these changes

@SakodaShintaro SakodaShintaro Awaiting requested review from SakodaShintaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Autumn60 @shmpwk