fix(aip_gen2_x2_launch): fix lidar.launch.xml to update nebula #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomohitoAndo
reviewed
Feb 6, 2025
TomohitoAndo
reviewed
Feb 6, 2025
kotaro-hihara
changed the title
|
35b7802 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nebula v0.2.3から必要になる引数(ptp_lock_threshold, udp_only)を追加
lidar.launch.xmlから直接nebula_node_containerを使用するように変更 (中継launchにしか記述なかったものを追加)
本PR追加後pilot-auto.x2 v4.1.0のnebulaをv0.2.3（もしくはx2_gen2用ブランチ）に変更、aip_launcherのhash更新予定
この引数込みでnebula v0.2.3がlsim, psimが動くこと確認済み(nebula v0.2.1でも動く)