Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mrm_handler): mrm recoverable option #1818

Merged
merged 8 commits into from
Feb 17, 2025

Conversation

TomohitoAndo
Copy link

@TomohitoAndo TomohitoAndo commented Feb 14, 2025

Description

PR for launcher: tier4/autoware_launch#760

Tip

These options are disabled as default parameters in the launcher PR, and there are no behavior changes as default.

This PR cherry-picks these PRs:

This PR introduces the following features:

  • autoware_mrm_handler
    • Added an option to make MRM behavior non-recoverable when it occurs.
    • This option is enabled when is_mrm_recoverable is set to false.
  • recovery node
    • Even if is_mrm_recoverable is set to false, the MRM behavior will be recovered unless it is associated with a fatal_error in the diagnostic_graph tree.
    • This node will not be launched as default.

Related links

TIER IV INTERNAL LINK

TIER IV INTERNAL JIRA

How was this PR tested?

I confirmed that the MRM works when the associated diagnostics occuered.
I used default config for this test.

mrm_recoverable_test.mp4

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

TomohitoAndo and others added 4 commits February 14, 2025 12:01
* feat(mrm_handler): mrm recoverable option (#1316)

* implement is_mrm_recoverable option of mrm_handler

* add pull over after stopped option

* update json schema of mrm_handler

Signed-off-by: Tomohito Ando <[email protected]>

* feat: implement service for clear MRM behavior (#1511)

* implement service for clear MRM behavior

* clang format

Signed-off-by: Tomohito Ando <[email protected]>

* feat: implement MRM automatic recovery feature

Signed-off-by: Tomohito Ando <[email protected]>

* fix typo

Signed-off-by: Tomohito Ando <[email protected]>

---------

Signed-off-by: Tomohito Ando <[email protected]>
Co-authored-by: Shohei Sakai <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
@TomohitoAndo TomohitoAndo changed the title feat(mrm_handler): mrm recoverable option (#1316) (#1654) feat(mrm_handler): mrm recoverable option Feb 14, 2025
Signed-off-by: Tomohito Ando <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
@TomohitoAndo TomohitoAndo marked this pull request as ready for review February 14, 2025 09:38
Copy link

@saka1-s saka1-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rej55 rej55 merged commit 3f4d389 into beta/v0.41 Feb 17, 2025
29 of 31 checks passed
@rej55 rej55 deleted the feat/cherry-pick-mrm-recovery branch February 17, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants