Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Fix readability + minor semantic issues in Python files #5

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

nnmm
Copy link

@nnmm nnmm commented Nov 26, 2020

This is only a separate PR to make the diff smaller. I know style changes are not needed yet, but this took five minutes and I was waiting anyway for things to compile.

  • Removed #!/usr/bin/env python, it is not needed for libraries at all and even for the executable, ros2 run takes care of selecting the interpreter
  • Fixed lint issues pointed out by flake8 and ran isort
  • Changed double underscores to single underscores since double underscores have special meaning in Python.

@nnmm nnmm requested a review from TakaHoribe November 26, 2020 17:26
@TakaHoribe
Copy link

@nnmm The code looks good to me. Did you confirm this script runs correctly?

@nnmm
Copy link
Author

nnmm commented Dec 3, 2020

@TakaHoribe Yes, I ran the script and it looks fine.

Copy link

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Then, let's merge.

@TakaHoribe
Copy link

@nnmm Can we merge this now, or better to wait until the #2 is merged?

@nnmm
Copy link
Author

nnmm commented Dec 3, 2020

@TakaHoribe it can be merged now.

@TakaHoribe TakaHoribe merged commit c801ed3 into tier4:ros2 Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants