Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_map_msgs): add LocalCartesian const #152

Closed
wants to merge 1 commit into from

Conversation

sebekx
Copy link

@sebekx sebekx commented Nov 5, 2024

Related Links

Description

Add LocalCartesian const to MapProjectionInfo to extend autoware_geography_utils with LocalCartesian (WGS84) projection

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@yukkysaito
Copy link
Collaborator

@sebekx Thank you for the PR. Since this is synchronized with the README, could you also add an explanation for the coordinates being added to the README?
https://github.com/autowarefoundation/autoware.universe/blob/main/map/autoware_map_projection_loader/README.md

@mitsudome-r
Copy link
Collaborator

Could you recreate the PR on autoware_msgs?
As @TaikiYamada4 mentioned in this comment, we have migrated this to autoware_msgs as part of porting to Core.

@sebekx
Copy link
Author

sebekx commented Feb 5, 2025

Could you recreate the PR on autoware_msgs? As @TaikiYamada4 mentioned in this comment, we have migrated this to autoware_msgs as part of porting to Core.

created pr on autoware_msgs

@sebekx sebekx closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants